feat: add audio notification with mute toggle on peer join#424
Closed
GulshanJha00 wants to merge 3 commits intomuke1908:masterfrom
Closed
feat: add audio notification with mute toggle on peer join#424GulshanJha00 wants to merge 3 commits intomuke1908:masterfrom
GulshanJha00 wants to merge 3 commits intomuke1908:masterfrom
Conversation
GulshanJha00
commented
Feb 25, 2026
GulshanJha00
commented
- Added subtle audio notification when peer joins the chat
- Implemented mute toggle button in the header
- Persisted mute preference using localStorage
- Ensured safe audio playback handling
- Kept volume non-disruptive
- Use value ranging from 0 to 1 to keep the sound as per requirement inside /client/app.ts in 78th line
|
Owner
|
Stale PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.